Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #6007 RankMath plugin section #6029

Merged
merged 10 commits into from Jul 19, 2023
Merged

Closes #6007 RankMath plugin section #6029

merged 10 commits into from Jul 19, 2023

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Jul 5, 2023

Fixes #6007

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Tabrisrp Tabrisrp added the 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting label Jul 5, 2023
@Tabrisrp Tabrisrp self-assigned this Jul 5, 2023
@Tabrisrp Tabrisrp marked this pull request as ready for review July 10, 2023 21:12
@Tabrisrp Tabrisrp requested a review from a team July 10, 2023 21:12
@vmanthos vmanthos self-requested a review July 11, 2023 06:01
@wp-media wp-media deleted a comment from vmanthos Jul 14, 2023
vmanthos
vmanthos approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected! 👍

@vmanthos vmanthos added this to the 3.14.3 milestone Jul 19, 2023
@vmanthos vmanthos added this pull request to the merge queue Jul 19, 2023
Merged via the queue into develop with commit ecbcba2 Jul 19, 2023
8 checks passed
@vmanthos vmanthos deleted the enhancement/6007-rankmath branch July 19, 2023 05:52
@Mai-Saad Mai-Saad mentioned this pull request Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmanthos vmanthos vmanthos approved these changes

@mostafa-hisham mostafa-hisham mostafa-hisham approved these changes

Assignees

@Tabrisrp Tabrisrp

Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting waiting for feedback
Projects
None yet
Milestone
3.14.3
Development

Successfully merging this pull request may close these issues.

Support Rank Math - plugins section
3 participants
@Tabrisrp @vmanthos @mostafa-hisham