New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/6041 add incompatible plugins backend #6065
Enhancement/6041 add incompatible plugins backend #6065
Conversation
@mostafa-hisham Thanks for the PR. During the exploratory test can see that the transient Notes:
|
@Mai-Saad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, minor changes.
inc/Engine/Optimization/DynamicLists/IncompatiblePluginsLists/DataManager.php
Outdated
Show resolved
Hide resolved
inc/Engine/Optimization/DynamicLists/IncompatiblePluginsLists/DataManager.php
Show resolved
Hide resolved
$conditions = explode( '||', $conditions ); | ||
|
||
foreach ( $conditions as $condition ) { | ||
if ( get_rocket_option( trim( $condition ), false ) ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use the Options_Data class here by passing it to the constructor of the class
…ithub.com:wp-media/wp-rocket into enhancement/6041-add-incompatible-plugins-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected
Note:
- failed tests need to be checked at the 1st alpha
- translations for dynamic list update while valid /invalid license shall be checked in the prerelease
testrail-report-508.pdf
Description
Plugin part for add incompatible plugins in backend
Fixes #6041
Type of change
Is the solution different from the one proposed during the grooming?
No
How Has This Been Tested?
Checklist: