Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/6041 add incompatible plugins backend #6065

Merged
merged 15 commits into from Jul 28, 2023

Conversation

mostafa-hisham
Copy link
Contributor

Description

Plugin part for add incompatible plugins in backend

Fixes #6041

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

  • Locally
  • Unit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@mostafa-hisham mostafa-hisham marked this pull request as ready for review July 25, 2023 14:19
@mostafa-hisham mostafa-hisham requested a review from a team July 25, 2023 14:19
@mostafa-hisham mostafa-hisham self-assigned this Jul 25, 2023
@Mai-Saad Mai-Saad self-requested a review July 26, 2023 09:33
@Mai-Saad
Copy link

Mai-Saad commented Jul 26, 2023

@mostafa-hisham Thanks for the PR. During the exploratory test can see that the transient wpr_dynamic_lists_incompatible_plugins is not deleted after deleting WPR. Can you please check that?

Notes:

  • As per discussion, we need to add data to the live backend before the release so it grabs the correct list.
  • Currently the wpr_dynamic_lists_incompatible_plugins.json, is not in the WPR folder with installation. As per discussion, the new list file will be created after creating a new release on GitHub

@mostafa-hisham
Copy link
Contributor Author

@mostafa-hisham Thanks for the PR. During the exploratory test can see that the transient wpr_dynamic_lists_incompatible_plugins is not deleted after deleting WPR. Can you please check that?

@Mai-Saad
should be fixed now

Copy link
Contributor

@engahmeds3ed engahmeds3ed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, minor changes.

$conditions = explode( '||', $conditions );

foreach ( $conditions as $condition ) {
if ( get_rocket_option( trim( $condition ), false ) ) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use the Options_Data class here by passing it to the constructor of the class

@Tabrisrp Tabrisrp added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement 3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: dynamic lists labels Jul 26, 2023
…ithub.com:wp-media/wp-rocket into enhancement/6041-add-incompatible-plugins-backend
Copy link

@Mai-Saad Mai-Saad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected
Note:

  • failed tests need to be checked at the 1st alpha
  • translations for dynamic list update while valid /invalid license shall be checked in the prerelease
    testrail-report-508.pdf

@Mai-Saad Mai-Saad added this to the 3.14.3 milestone Jul 28, 2023
@Mai-Saad Mai-Saad added this pull request to the merge queue Jul 28, 2023
Merged via the queue into develop with commit e307f72 Jul 28, 2023
8 checks passed
@Mai-Saad Mai-Saad deleted the enhancement/6041-add-incompatible-plugins-backend branch July 28, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party compatibility Issues related to 3rd party compatibility like theme, plugin or hosting module: dynamic lists type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new backend exclusion field for Incompatible Plugins
4 participants