Divi compatibility: show admin notice to clear the used CSS when a template is updated #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ates_clear_rucss' into enhancement/5837-divi_save_templates_clear_rucss
Tabrisrp
requested changes
Jul 31, 2023
|
I forgot the tests, we have two public methods, going to add the tests for them now. |
Tabrisrp
requested changes
Aug 1, 2023
tests/Unit/inc/ThirdParty/Themes/Divi/handleDiviAdminNotice.php
Outdated
Show resolved
Hide resolved
tests/Unit/inc/ThirdParty/Themes/Divi/handleDiviAdminNotice.php
Outdated
Show resolved
Hide resolved
tests/Unit/inc/ThirdParty/Themes/Divi/handleDiviAdminNotice.php
Outdated
Show resolved
Hide resolved
Tabrisrp
approved these changes
Aug 1, 2023
|
@engahmeds3ed Thanks for the PR. |
…r_rucss # Conflicts: # inc/Engine/WPRocketUninstall.php
|
All done now |
Tabrisrp
approved these changes
Aug 4, 2023
|
@engahmeds3ed Thank you for the PR. There are a couple of scenarios that are failing. With Remove Unused CSS enabled and used CSS existing in the database:
For the second scenario, with Remove Unused CSS enabled and used CSS existing in the database:
Can you please look into these? |
vmanthos
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Working as expected. 👍
TestRail report: testrail-report-514.pdf
…ates_clear_rucss' into enhancement/5837-divi_save_templates_clear_rucss
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Show admin notice to clear the used CSS when a template is updated only when this template is used in any (page, post, tag, ...etc.)
Also added a new filter `` to enable/disable this functionality.
Fixes #5837
Type of change
Is the solution different from the one proposed during the grooming?
Yes it's changed a bit, you can check the discussion in the issue itself for more details.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Please delete the options that are not relevant.