Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use search_url or geter method based on polylang version #6081

Merged
merged 2 commits into from Aug 9, 2023

Conversation

mostafa-hisham
Copy link
Contributor

@mostafa-hisham mostafa-hisham commented Aug 2, 2023

Description

Please include a summary of the change and which issue is fixed/closed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #5967

Type of change

  • Enhancement (non-breaking change which improves an existing functionality)

Is the solution different from the one proposed during the grooming?

No

How Has This Been Tested?

  • locally

Checklist:

Please delete the options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mostafa-hisham mostafa-hisham self-assigned this Aug 2, 2023
@mostafa-hisham mostafa-hisham marked this pull request as ready for review August 2, 2023 07:18
@vmanthos vmanthos self-requested a review August 8, 2023 08:14
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected. 👍

NOTE

Issue, on trunk as well, discovered during testing for the current PR:
#6094

@vmanthos vmanthos added this pull request to the merge queue Aug 9, 2023
Merged via the queue into develop with commit cb7dd13 Aug 9, 2023
8 checks passed
@vmanthos vmanthos deleted the enhancement/5967-polylang-search-url branch August 9, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated Class Property search_url used with Polylang
3 participants