-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #6033 Add partial clean of SpinupWP cache #6100
Conversation
Access to the website and SFTP is on Bitwarden. |
@Tabrisrp Thanks for the PR. During exploratory testing, can see that Purge this URL from the Admin bar at page view or clear this cache from the posts list is not working (i.e not setting cache header to Miss) when permalinks without |
I updated the code to add a trailing slash to the URL to purge |
I can't find the reason why it's not working without trailingslash in the code itself. There is nothing that should impact it, looking at their code: https://github.com/spinupwp/spinupwp-plugin/blob/62ae3ec7c53f602f80cd10c742fae6c361c790f4/src/Cache.php#L289 We might need to ask them if there is a reason on their side |
@MathieuLamiot I am fine with that, can execute the test plan only while Permalinks having |
@MathieuLamiot @Tabrisrp @Mai-Saad Agreed, let's do it like that. As soon as the issue is opened, I'll reach SpinupWP and ask them to collaborate there |
Ok, @Tabrisrp can you open an issue? I think you have more insights on the matter :) Moving this to "Ready for QA" in case there are other things to check :) |
Working as expected with the following notes.
|
Description
Add partial clean of SpinUpWP cache on our clean actions
Fixes #6033
Type of change
How Has This Been Tested?
Checklist: