Fixes 6132: Added tests and new logic for supporting pseudoclasses

[CrochetFeve0251]

Description

Add support for pseudoclasses for the bg css ll.
For that we refactored the logic from the MappingParser.

Fixes #6132

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No.

Checklists

Generic development checklist

• My code follows the style guidelines of this project, with adapted comments and without new warnings.
• I have added unit and integration tests that prove my fix is effective or that my feature works.
• The CI passes locally with my changes (including unit tests, integration tests, linter).
• Any dependent changes have been merged and published in downstream modules.
• If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

• I triggered all changed lines of code at least once without new errors/warnings/notices.
• I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
• I validated all test plan the QA Review asked me to.

If not, detail what you could not test.

Please describe any additional tests you performed.

[engahmeds3ed]

It'll be easier for us to maintain or even review if u changed those two anonymous functions to normal methods in the class.
You can also simplify things by creating a new method to return the filtered pseudo_elements_to_remove

what do u think?

[CrochetFeve0251]

It'll be easier for us to maintain or even review if u changed those two anonymous functions to normal methods in the class. You can also simplify things by creating a new method to return the filtered pseudo_elements_to_remove

what do u think?

The second one needs the context I think that using normal function will make it confusing as we will have to use property which is not natural.

[engahmeds3ed]

No need to create a property, I meant something like that (that's a draft):

    private function get_pseudo_elements_to_remove() {
	    $original_pseudo_elements = [
		    ':before',
		    ':after',
		    ':first-line',
		    ':first-letter',
		    ':active',
		    ':hover',
		    ':focus',
		    ':visited',
		    ':focus-within',
		    ':focus-visible',
	    ];

	    /**
	     * Pseudo elements to remove from lazyload CSS selector.
	     *
	     * @param string[] Pseudo elements to remove.
	     */
	    $pseudo_elements_to_remove = apply_filters( 'rocket_lazyload_css_ignored_pseudo_elements', $original_pseudo_elements );

	    if ( ! is_array( $original_pseudo_elements ) ) {
		    $pseudo_elements_to_remove = $original_pseudo_elements;
	    }

	    usort(
		    $pseudo_elements_to_remove,
		    static function ( $first, $second ) {
			    if ( strlen( $first ) === strlen( $second ) ) {
				    return 0;
			    }
			    return ( strlen( $first ) > strlen( $second ) ) ? -1 : 1;
		    }
	    );

        return $pseudo_elements_to_remove;
    }

    public function remove_pseudo_classes_for_selector( $selector ) {
	    $selector = preg_replace( '/::[\w-]+/', '', $selector );

	    $pseudo_elements_to_remove = $this->get_pseudo_elements_to_remove();
	    foreach ( $pseudo_elements_to_remove as $element ) {
		    $selector = str_replace( $element, '', $selector );
	    }
	    if ( in_array( substr( $selector, -1 ), [ '&', '~', '+', '>' ], true ) ) {
		    $selector .= '*';
	    }

	    if ( ! $selector ) {
		    return 'body';
	    }

	    return $selector;
    }

	protected function remove_pseudo_classes( string $selector ): string {
		$result = preg_replace( '/::[\w\-]+/', '', $selector );



		$selectors = explode( ',', $selector );

		$selectors = array_map( array( $this, 'remove_pseudo_classes_for_selector' ), $selectors );

		$selectors = array_unique( $selectors );

		$selector = implode( ',', $selectors );

		if ( ! $selector ) {
			return 'body';
		}

		return (string) $selector;
	}

[vmanthos]

The PR is working. 👍

NOTE

#6158 was discovered during the investigation of this feature.
We'll need to re-test pseudo classes when that's fixed.