Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6181: DB Query can cause timeout #6218

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Oct 11, 2023

Description

On a site with many many private posts, any action that involves post cache clearing will result in a timeout error.
DB Queries have been optimised to make it more responsive and quicl.

Fixes #6181

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld added type: bug Indicates an unexpected problem or unintended behavior severity: major Feature is not working as expected and no work around available labels Oct 11, 2023
@Miraeld Miraeld requested a review from a team October 11, 2023 22:45
@Miraeld Miraeld self-assigned this Oct 11, 2023
@Miraeld Miraeld force-pushed the bug/6181-db-query-timeout branch 2 times, most recently from a05008a to dd422ff Compare October 12, 2023 07:35
@vmanthos vmanthos self-requested a review October 25, 2023 09:09
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected as far as the feature goes.

NOTE

I haven't been able to reproduce the original issue although I tried to do so in different environments. Testing was mainly about preventing regressions.

TestRail report: testrail-report-540.pdf

@vmanthos vmanthos merged commit 87aead4 into develop Oct 30, 2023
7 of 8 checks passed
@vmanthos vmanthos deleted the bug/6181-db-query-timeout branch October 30, 2023 12:44
@vmanthos vmanthos added this to the 3.15.4 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: major Feature is not working as expected and no work around available type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_all_private_urls() DB query can cause timeout issues on sites with thousands of private posts
4 participants