Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #4943: Delete transients on plugin uninstallation #6386

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jan 17, 2024

Description

Some transients weren't deleted once the plugin gets uninstalled from a website.

Fixes #4943

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld added type: bug Indicates an unexpected problem or unintended behavior Module: dashboard labels Jan 17, 2024
@Miraeld Miraeld self-assigned this Jan 17, 2024
@Mai-Saad
Copy link

Mai-Saad commented Jan 19, 2024

Related test plan https://wpmediaqa.testrail.io/index.php?/runs/view/804&group_by=cases:section_id&group_order=asc&group_id=5010

Note: As per discussion, options are not in the scope of the current PR. Thus wp_rocket_last_base_url is out of scope.

@piotrbak
Copy link
Contributor

@Miraeld @Mai-Saad Based on our conversation today, in order not to make direct deletes from the wp_options table, let's rever the deletion of the dynamic transients.

Thank you @Mai-Saad for bringing this to attention, sorry @Miraeld for changing the requirements.

@Miraeld Miraeld force-pushed the fix/4943-transients-deleted-unistall branch from 7969c00 to f7bc5f6 Compare January 22, 2024 08:12
@Miraeld
Copy link
Contributor Author

Miraeld commented Jan 22, 2024

@Mai-Saad There is no need for review again, I've deleted the part that was deleting dynamic transients :)

@Miraeld Miraeld force-pushed the fix/4943-transients-deleted-unistall branch from 1079c8a to c079c12 Compare January 30, 2024 06:29
@Miraeld
Copy link
Contributor Author

Miraeld commented Jan 30, 2024

@Mai-Saad , here is the related QA test plan results:
testrail-report-565.pdf

@Mai-Saad Mai-Saad added this pull request to the merge queue Jan 31, 2024
Merged via the queue into develop with commit f148794 Jan 31, 2024
9 checks passed
@Mai-Saad Mai-Saad deleted the fix/4943-transients-deleted-unistall branch January 31, 2024 14:53
@Mai-Saad
Copy link

Mai-Saad commented Feb 1, 2024

During the exploratory test of prerelease, these transients won't be deleted after removing wpr
1- while WPML is active
rocket_get_refreshed_fragments_cache_en
if WPML is off
rocket_get_refreshed_fragments_cache
will be deleted.
2- While WPR deleted on multisite, all transients won't be deleted for subsite (network activation was on, same with enable/site)
Agreed that no GH is needed for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: dashboard type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some transients aren't deleted after deleting WP Rocket
5 participants