Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6349: Update renewal banner with discount percentage instead of difference #6397

Conversation

jeawhanlee
Copy link
Contributor

Description

This PR Updates the Renewal banner with discount percentage.

Fixes #6349

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement Module: dashboard labels Jan 19, 2024
@jeawhanlee jeawhanlee self-assigned this Jan 19, 2024
@jeawhanlee jeawhanlee requested a review from a team January 19, 2024 12:26
@jeawhanlee jeawhanlee marked this pull request as ready for review January 19, 2024 12:54
@Mai-Saad Mai-Saad self-requested a review January 29, 2024 09:45
@Mai-Saad
Copy link

Mai-Saad commented Jan 29, 2024

working as expected with the following note (agreed to be ok)

@Mai-Saad Mai-Saad added this pull request to the merge queue Jan 29, 2024
Merged via the queue into develop with commit 7abd181 Jan 29, 2024
9 checks passed
@Mai-Saad Mai-Saad deleted the enhancement/6349-renewal-banner-with-discount-percentage-instead-of-difference branch January 29, 2024 11:54
wordpressfan pushed a commit that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: dashboard type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renewal banner with discount percentage instead of difference
4 participants