Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6394: Reintroduce limit preload at job level #6409

Merged
merged 2 commits into from Jan 31, 2024

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Jan 24, 2024

Description

Re-introduction of the preload limit at the job level

Fixes #6394

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Is the solution different from the one proposed during the grooming?

No

Checklists

Generic development checklist

  • My code follows the style guidelines of this project, with adapted comments and without new warnings.
  • I have added unit and integration tests that prove my fix is effective or that my feature works.
  • The CI passes locally with my changes (including unit tests, integration tests, linter).
  • Any dependent changes have been merged and published in downstream modules.
  • If applicable, I have made corresponding changes to the documentation. Provide a link to the documentation.

Test summary

  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I validated all Acceptance Criteria of the related issues. (If applicable, provide proof).
  • I validated all test plan the QA Review asked me to.

@Miraeld Miraeld added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Jan 24, 2024
@Miraeld Miraeld self-assigned this Jan 24, 2024
@Mai-Saad
Copy link

Mai-Saad commented Jan 26, 2024

Related test plan https://wpmediaqa.testrail.io/index.php?/runs/view/808&group_by=cases:section_id&group_order=asc
Note: will be nice to do a performance check vs trunk with a big batch size

@jeawhanlee
Copy link
Contributor

During test plan execution, When helper plugin is used: https://drive.google.com/uc?id=1JDqh9xV6zyLcD3OR_Njsxn8KW_PYGoac with webp enabled in addon, only webp versions are generated. Same thing is happening on trunk but working fine on 3.12.3 with no webp version generated.

@Mai-Saad Mai-Saad added this pull request to the merge queue Jan 31, 2024
Merged via the queue into develop with commit d9b4209 Jan 31, 2024
9 checks passed
@Mai-Saad Mai-Saad deleted the enhancement/6394-bring-back-batch-limit-preload branch January 31, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: preload type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring back batch limit on Preload at job level
5 participants