Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6438: Adapt the URL for the job so the SaaS uses the correct one #6455

Merged

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Feb 28, 2024

Description

Fixes #6438

Documentation

Technical documentation

We use the function user_trailingslashit when we send the job to the SaaS so the SaaS can use the right URL to proceed and avoid redirections.

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Miraeld Miraeld added this to the 3.15.10 milestone Feb 28, 2024
@Miraeld Miraeld requested a review from a team February 28, 2024 13:33
@Miraeld Miraeld self-assigned this Feb 28, 2024
@Mai-Saad
Copy link

Mai-Saad commented Mar 1, 2024

@Miraeld
Copy link
Contributor Author

Miraeld commented Mar 1, 2024

I've run tests, here are the results:
testrail-report-579.pdf

@Mai-Saad Mai-Saad added this pull request to the merge queue Mar 1, 2024
Merged via the queue into develop with commit 1146fd7 Mar 1, 2024
9 checks passed
@Mai-Saad Mai-Saad deleted the fix/6438-change-url-sent-to-saas-for-trailing-slash branch March 1, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants