Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6432: Bail out from beacon (screen size) threshold modification #6593

Conversation

Miraeld
Copy link
Contributor

@Miraeld Miraeld commented Apr 25, 2024

Description

Fixes #6432

Documentation

User documentation

Thresholds have been modified for the Desktop version from 1920x1080 to 1700x700
and safeguard added

Technical documentation

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

@Miraeld Miraeld added the type: enhancement Improvements that slightly enhance existing functionality and are fast to implement label Apr 25, 2024
@Miraeld Miraeld added this to the 3.16 milestone Apr 25, 2024
@Miraeld Miraeld requested a review from a team April 25, 2024 14:06
@Miraeld Miraeld self-assigned this Apr 25, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 75.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (91077f9) 36964 14160 38.31%
Head commit (d288c85) 36970 (+6) 14164 (+4) 38.31% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6593) 8 6 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@MathieuLamiot MathieuLamiot merged commit 9a9e1f4 into feature/lcp-above-the-fold-optimization Apr 25, 2024
13 checks passed
@MathieuLamiot MathieuLamiot deleted the enhancement/6432-bail-out-from-beacon-conditions-2 branch April 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.16 - Bail out from beacon script if already processed or not acceptable screen size
2 participants