Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6632: Image Optimization Tab Update #6675

Merged
merged 9 commits into from
May 29, 2024

Conversation

jeawhanlee
Copy link
Contributor

Description

Updates the UI of the Image Optimization tab.

Fixes #6632

Documentation

User documentation

Explain how this code impacts users.

Technical documentation

Explain how this code works. Diagram & drawings are welcomed.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

New dependencies

wp-admin/includes/plugin-install.php

Risks

None

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Documentation

  • I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
  • The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
  • I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I listed the introduced external dependencies explicitely on the PR.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

  • I handled errors when needed.
  •  I wrote user-facing messages that are understandable and provide actionable feedbacks.
  • I prepared ways to observe the implemented system (logs, data, etc.).

Risks

  •  I explicitely mentioned performance risks in the PR.
  • I explicitely mentioned security risks in the PR.

@jeawhanlee jeawhanlee self-assigned this May 28, 2024
@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement module: user interface labels May 28, 2024
Copy link

codacy-production bot commented May 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for e78c9fe1 0.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e78c9fe) Report Missing Report Missing Report Missing
Head commit (6438439) 37221 14389 38.66%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6675) 37 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeawhanlee jeawhanlee marked this pull request as ready for review May 28, 2024 15:41
@jeawhanlee jeawhanlee requested a review from a team May 28, 2024 15:54
@jeawhanlee
Copy link
Contributor Author

State without Imagify installed.

Screenshot 2024-05-28 at 18 40 10

@jeawhanlee
Copy link
Contributor Author

State with Imagify Installed but not activated.

Screenshot 2024-05-28 at 18 42 16

@jeawhanlee
Copy link
Contributor Author

State with Imagify Installed & Activated.

Screenshot 2024-05-28 at 18 44 19

@marija-nikolic
Copy link
Collaborator

State with Imagify Installed & Activated.

Screenshot 2024-05-28 at 18 44 19

We don't have an Image Optimization tab at all when Imagify is Installed and Activated. That is currently the case.

inc/Engine/Admin/Settings/Render.php Outdated Show resolved Hide resolved
views/settings/page-sections/imagify.php Outdated Show resolved Hide resolved
@Tabrisrp
Copy link
Contributor

Display is good 👍🏼

@Tabrisrp Tabrisrp added this pull request to the merge queue May 29, 2024
@Tabrisrp Tabrisrp added this to the 3.16.1 milestone May 29, 2024
Merged via the queue into develop with commit ec79762 May 29, 2024
12 of 14 checks passed
@Tabrisrp Tabrisrp deleted the enhancement/6632-image-optimization-tab-update branch May 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: user interface type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Optimization Tab Update
4 participants