Close all shortcodes, even when no inner content exist. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preventing issues with not closed shortcodes and following shortcodes with inner contents: http://codex.wordpress.org/Shortcode_API#Unclosed_Shortcodes
|
Indeed a very welcome change! |
|
Looks good to me. |
* upstream/master: (30 commits) Update notice text Update docs and revert some other modifications Remove loading of scripts from core WP. Grunt task to update. log path location Check for wp-includes and not just that the abspath directory exists Revert adding double tests Update Jasmine Update dev path logic and error if not found Add user_select field (wp-shortcake#614) Update dev examples (wp-shortcake#613) Term select fix (wp-shortcake#612) update pot file (wp-shortcake#596) Create translation file for Japanese (wp-shortcake#594) Add Term Select (wp-shortcake#604) pass correct path to WP update readme Throw fatal if running tests and test install not found Fix JS error If no abspath provided, read from environment variable Allow passing abspath as an option ...
|
Finally given this a test. All works fine. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preventing issues with not closed shortcodes and following shortcodes with inner contents.
See: http://codex.wordpress.org/Shortcode_API#Unclosed_Shortcodes