Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js in Legacy Faust #1886

Merged
merged 4 commits into from
May 14, 2024
Merged

Update Next.js in Legacy Faust #1886

merged 4 commits into from
May 14, 2024

Conversation

ChrisWiegman
Copy link
Contributor

@ChrisWiegman ChrisWiegman commented May 13, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

This PR does two things:

  1. It bumps Next.js to 12.3.4 on associated packages
  2. On packages with Next 14, whereas they had < 14.1.1 it updates Next to 14.2.3
  3. It adds plugin testing for WordPress 6.5

Related Issue(s):

Initially I intended this to address a dependabot issue for Next however it does not affect Next 12. There are, however, other version of Next

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 47a5bc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@faustjs/next Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ChrisWiegman ChrisWiegman changed the title Update Next.js to 14.x Update Next.js in Legacy Faust May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ChrisWiegman ChrisWiegman marked this pull request as ready for review May 13, 2024 16:20
@ChrisWiegman ChrisWiegman requested a review from a team as a code owner May 13, 2024 16:20
Copy link
Member

@theodesp theodesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChrisWiegman ChrisWiegman merged commit 3c78b75 into canary May 14, 2024
15 checks passed
@ChrisWiegman ChrisWiegman deleted the MERL-1384 branch May 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants