Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PHPCS and coding standards to the current version. #1894

Merged
merged 3 commits into from
May 30, 2024

Conversation

ChrisWiegman
Copy link
Member

@ChrisWiegman ChrisWiegman commented May 29, 2024

Tasks

  • I have signed a Contributor License Agreement (CLA) with WP Engine.
  • If a code change, I have written testing instructions that the whole team & outside contributors can understand.
  • I have written and included a comprehensive changeset to properly document the changes I've made.

Description

Per squizlabs/PHP_CodeSniffer#3932, we don't actually need to update the package name as they were able to maintain the name on package. That said, our implementation is still out of date.

Related Issue(s):

Testing

As code is to existing tests, no additional testing has been implemented.

Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: a9a3489

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented May 29, 2024

📦 Next.js Bundle Analysis for @faustwp/getting-started-example

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ChrisWiegman ChrisWiegman marked this pull request as ready for review May 29, 2024 18:15
@ChrisWiegman ChrisWiegman requested a review from a team as a code owner May 29, 2024 18:15
Copy link
Member

@theodesp theodesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChrisWiegman ChrisWiegman merged commit 2c581ad into canary May 30, 2024
18 checks passed
@ChrisWiegman ChrisWiegman deleted the update-coding-standards branch May 30, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants