-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security(ws): update ws vulnerable version #1917
base: canary
Are you sure you want to change the base?
Conversation
|
"next-secure-headers": "^2.2.0" | ||
}, | ||
"optionalDependencies": { | ||
"@wordpress/scripts": "^28.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to move this here to avoid installing the @wordpress/scripts
which includes ws
and I cannot seem to override it. It starting from scratch, the faust cli
will ask you to install the @wordpress/scripts
on the first time you run the blockset
command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does worry me a bit. Can we submit an upstream PR to make this more a temporary workaround than a permanent one?
📦 Next.js Bundle Analysis for @faustwp/getting-started-exampleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Tasks
Description
Fixes GHSA-3h5v-q93c-6h6q
Related Issue(s):
Testing
Screenshots
Documentation Changes
Dependant PRs