Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds mediaDetails field in CoreImage block. #151

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Feat: Adds mediaDetails field in CoreImage block. #151

merged 5 commits into from
Sep 21, 2023

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Sep 20, 2023

Description

This PR adds a new field mediaDetails in CoreImage block that is used to extract more information about the associated image attachment without having to perform an additional query.

Relevant Tickets

#144

Testing

mediaDetails field is queryable in CoreImage block. For example

{
  posts {
    nodes {
      editorBlocks {
        ... on CoreImage {
          mediaDetails {
            file
            sizes {
              name
              width
              height
              sourceUrl
            }
            height
            width
          }
        }
      }
    }
  }
}
Screenshot 2023-09-20 at 13 35 44

@theodesp theodesp requested a review from a team as a code owner September 20, 2023 12:32
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2023

🦋 Changeset detected

Latest commit: 2b0ca4a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpengine/wp-graphql-content-blocks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

theodesp and others added 2 commits September 20, 2023 14:19
Co-authored-by: John Parris <john.parris@wpengine.com>
@matthewguywright
Copy link
Contributor

LGTM

@theodesp theodesp merged commit 54affda into main Sep 21, 2023
7 checks passed
@theodesp theodesp deleted the MERL-1095 branch September 21, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants