Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD: Make release dependent on tests. #155

Merged
merged 4 commits into from
Oct 10, 2023
Merged

CI/CD: Make release dependent on tests. #155

merged 4 commits into from
Oct 10, 2023

Conversation

theodesp
Copy link
Member

@theodesp theodesp commented Oct 9, 2023

Description

  • Runs Release step when both "Test Plugin" and "End-to-End Tests" are successful.

@theodesp theodesp requested a review from a team as a code owner October 9, 2023 11:46
@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2023

⚠️ No Changeset found

Latest commit: 3102d9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TeresaGobble
Copy link
Contributor

Thank you for this addition, @theodesp! This is going to be such a big safety feature for releases. 🚀

Would you please provide some instruction on how to test this out? Testing for release behavior is a bit tricky, and I'm not sure what the best workflow is for it.

@theodesp theodesp merged commit 1415e91 into main Oct 10, 2023
7 checks passed
@theodesp theodesp deleted the MERL-990 branch October 10, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants