Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken user-approved-filter (WP 4.4+) #44

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

judomu
Copy link
Contributor

@judomu judomu commented Sep 5, 2016

Fixed the broken user-approved-filter by extending it to use two separate inputs for the top and bottom bar.

The PR fixes the Issue-#42. Instead of the PR-#43 it uses the $which-parameter (provided by WordPress since Release 4.6.0), see code:

/**
 * Fires just before the closing div containing the bulk role-change controls
 * in the Users list table.
 *
 * @since 3.5.0
 * @since 4.6.0 The `$which` parameter was added.
 *
 * @param string $which The location of the extra table nav markup: 'top' or 'bottom'.
 */
do_action( 'restrict_manage_users', $which );

@picklewagon
Copy link
Collaborator

This is great! Thank you for this PR. I'm working on an update and this will be included.

@picklewagon picklewagon merged commit 9161f58 into wpexpertsio:master Oct 4, 2016
picklewagon pushed a commit that referenced this pull request Oct 4, 2016
picklewagon added a commit that referenced this pull request Nov 1, 2016
= 1.7.4 =
* Fixed: Corrected erroneous SQL query when filtering users
* Fixed: User filters
  * Courtesy of [julmuell](https://github.com/julmuell)
  * #44
* Fixed: Show a user status in the filters only if at least one user has that status

# Conflicts:
#	readme.txt
picklewagon added a commit that referenced this pull request Nov 1, 2016
* Fixed: Corrected erroneous SQL query when filtering users
* Fixed: User filters
  * Courtesy of [julmuell](https://github.com/julmuell)
  * #44
* Fixed: Show a user status in the filters only if at least one user has that status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants