Skip to content
This repository has been archived by the owner on Jul 22, 2018. It is now read-only.

Java debug fix. Added missing libs.deployDir #96

Merged
merged 2 commits into from Jan 20, 2017

Conversation

sciencewhiz
Copy link
Contributor

Incorporates and supersedes #91. Adds missing libs.deployDir to debug-deploy. Updates debug-deploy to be like deploy target

gerth2 and others added 2 commits January 12, 2017 20:31
Debug deploy target appeared to be missing libs.deployDir , which was preventing a successful debug deploy from eclipse. I"m not sure if this is all of the required changes (as I still have to manually restart the remote java application), but this does allow the deploy to go through as expected.
Include all native libs and fix user library debugd-eploy.
Run clean on debug-deploy like regular deploy
@sciencewhiz
Copy link
Contributor Author

@gerth2 This fixes java debugging for me. Does it fix your problems as well?

@gerth2
Copy link

gerth2 commented Jan 16, 2017

Hmmm possibly? Will have test board access tomorrow morning, will check then!

I think I still had issues with the post-deploy connection between the Eclipse debugger and the remote JVM on the RIO starting up, but I haven't dug into that much more yet... I presume some of that behavior defined is within the the definition of the WPIlib eclipse plugin, which hasn't been changed in our series of updates yet. Some of it may also be my eclipse settings....I guess I still have much to actually look into </stream_of_consciousness>

@gerth2
Copy link

gerth2 commented Jan 16, 2017

Double checked - this does not 100% fix my issues. Although the ant build goes through without errors, Eclipse cannot establish the remote debug connection to the RIO. The same issue is present from at least one other user. (see https://www.chiefdelphi.com/forums/showthread.php?p=1631965#post1631965)... Will do some more investigation soon....

@Kevin-OConnor
Copy link
Contributor

Do you know which option of resolving the roboRIO the ant deploy is using when you are seeing the debugger fail to connect? The debugger will only connect using the mDNS address right now. The ant deploy has many more resolution options in it.

@gerth2
Copy link

gerth2 commented Jan 16, 2017

Per the console output from manually running "ant debug-deploy", yes I am getting the debug and deploy to find the robot over mdns:

get-target-ip:
     [echo] Trying Target: roboRIO-1736-FRC.local
     [echo] roboRIO found via mDNS

@gerth2
Copy link

gerth2 commented Jan 16, 2017

More debugging: It would seem that if I manually run the ant debug-deploy build, and then go to eclipse to run the debug build from the GUI, the debugger connects at the same time as the ant build starts (from eclipse) - is there any chance the eclipse debug connect is not waiting for the ant build to finish before it attempts to connect to the RIO with a debugger?

@PeterJohnson PeterJohnson merged commit 2233944 into wpilibsuite:master Jan 20, 2017
@PeterJohnson
Copy link
Member

Please open a separate issue for the other debug issues.

@gerth2
Copy link

gerth2 commented Jan 20, 2017

Sounds good. I definitely concur the change from this PR is needed. I will open separate issue. Thanks folks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants