-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command framework for C++ #248
New command framework for C++ #248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a command does not require a subsystem, the value "None" is used in the export, which doesn't compile. The templates need to check if the subsystem is None.
For example in the .h
#include "Subsystems/None.h"
explicit AutonomousCommand(None* none);
in the .cpp:
AutonomousCommand::AutonomousCommand(None* none) :m_none(none){
AddRequirements({m_none});
Update Robot.c/h with new command template Export OI includes in RobotContainer to Commands get Included Fix RunsWhenDisabled in Command
This is the file I'm using to test |
I still get some compile errors when I build with the project posted above. |
I've fixed several issues over the weekend. Two more I've found are that commands that don't require a subsystem don't export correctly in RobotContainer JoystickButtons, they subsystem export with &m_none instead of blank. Also, parameters don't export correctly. |
Comments from @prateekma:
|
Need to standardize on the template names with Java and remove OI |
Update to export New Command Framework. Fixes wpilibsuite#191 Use uniform initialization in header. Fixes wpilibsuite#80 Co-authored-by: Joe <sciencewhiz@users.noreply.github.com>
This updates RobotBuilder to create the new c++ commands. Some cleanup and formatting is still required.