Chooser - Update Selected Value #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinShalit
force-pushed
the
sendableChooserUpdateSelected
branch
from
250494d
to
056b912
Compare
|
|
||
| if (source.getString(SELECTED) == null) { | ||
| source.putString(SELECTED, source.getString(DEFAULT, choices.get(0))); | ||
| } |
There was a problem hiding this comment.
I think you need to use the getString(key, defaultValue) override. The robot by default does not set the key, so this would end up throwing an exception. source.getString(SELECTED, null) == null should work.
|
Also the intellij changes should be a separate PR. |
|
When you do move the intellij changes, just ignore all of .idea/, not just parts of it. No IDE-specific configs should be making it into our repos. |
AustinShalit
force-pushed
the
sendableChooserUpdateSelected
branch
from
056b912
to
a6376f5
Compare
|
This is ready for review. |
|
Code looks good to me, other then we are going to want all these commits squashed into 1 before merging. I don't have a Rio to test with however, but this should work. |
|
Do you want me to squash or is the GitHub squash ok? Tested on a RIO -- works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
If the selected value in networktables is null and we have a selected value. Update networktables. If we do not have a selected value, use the default. If there is no default, use the first option.