Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vscode system http certificates #398

Merged
merged 2 commits into from Feb 19, 2024

Conversation

spacey-sooty
Copy link
Contributor

Resolves #395

@sciencewhiz
Copy link
Collaborator

I don't think we want to set it true, I think we want to delete it (since true is the default).

I have the lingering worry about breaking someone, but this should be ok because it only affects new installations as long as we don't break major vendordeps downloads. The SetIfNotAet wouldn't change existing installations.

to verify you should try downloading all the vendordeps we list in FRC docs. You'd have to do it either in a clean installation or manually change the flag in vs-code, instructions are in the CD thread

the commit message / PR title doesn't describe the change. This has nothing to do with build or macOS. Something like enable Vs Code system http certificates would be accurate.

@spacey-sooty spacey-sooty changed the title [build] re enable macos signing [build] enable Vs Code system http certificates would be accurate Feb 2, 2024
@PeterJohnson PeterJohnson changed the title [build] enable Vs Code system http certificates would be accurate Enable vscode system http certificates Feb 2, 2024
@PeterJohnson PeterJohnson merged commit d9b79ca into wpilibsuite:main Feb 19, 2024
8 checks passed
@spacey-sooty spacey-sooty deleted the enable-signing branch February 19, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider enabling VS Code system certificates again
3 participants