You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
It seems the best way to handle state at runtime with command factories is with suppliers being fed into commands. However, TrapezoidProfileCommand, for example, doesn't support this. This means it has to be wrapped in a DeferredCommand, leading to a lot of annoying complexity.
Describe the solution you'd like
I think the simplest solution to this issue is to replace state with suppliers in the various classes that need it. To continue supporting existing functionality, they could have alternate constructors that set the supplier to supply the arguments.
Also see #5150 for deferred commands, and the pitfall surrounding using ProxyCommand for this.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
It seems the best way to handle state at runtime with command factories is with suppliers being fed into commands. However,
TrapezoidProfileCommand
, for example, doesn't support this. This means it has to be wrapped in aDeferredCommand
, leading to a lot of annoying complexity.Describe the solution you'd like
I think the simplest solution to this issue is to replace state with suppliers in the various classes that need it. To continue supporting existing functionality, they could have alternate constructors that set the supplier to supply the arguments.
Also see #5150 for deferred commands, and the pitfall surrounding using
ProxyCommand
for this.The text was updated successfully, but these errors were encountered: