Refactor TrapezoidProfile API #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcmogul
added
breaking
|
Is there a way to make this less immediately breaking from a user perspective, eg with deprecated functions? Or is a hard break required? |
|
I think we can have separate constructor and calculate() overloads, though using the new ctor overload with the old calculate() will have undefined behavior. |
|
How about a boolean variable, |
|
That'll work. |
|
Do we still need that "breaking" tag if we only deprecated functions? |
Gold856
force-pushed
the
trapezoidprofile-refactor
branch
from
77e3e16
to
bf34bd9
Compare
calcmogul
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctor args were moved to
calculate, all examples were updated, command and subsystem updated as well, and anything else that made it not compile was updated. Fixes #5453.