Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New commands: add docs to end() #2450

Merged
merged 6 commits into from
Mar 28, 2020
Merged

Conversation

Starlight220
Copy link
Member

helps #2441

Co-Authored-By: Austin Shalit <austinshalit@gmail.com>
@AustinShalit
Copy link
Member

You also need to update the year in the copyright header.

@AustinShalit
Copy link
Member

Build is failing because:

https://dev.azure.com/wpilib/wpilib/_build/results?buildId=11603&view=logs&j=22fea640-1099-5f32-ec5d-316ad83f359a&t=67082dda-a192-5384-c7c3-5295d6656bc0&l=231

/__w/1/s/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java:40: error: reference not found
   *<p>Do not schedule commands here that share requirements with this command. Use {@link #andThen(Command)} instead.

I think the link needs to be {@link #andThen(Command...)}

@AustinShalit
Copy link
Member

[ant:checkstyle] [ERROR] /Users/runner/runners/2.165.2/work/1/s/wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java:40: Line is longer than 100 characters (found 121). [LineLength]

You should be able to check these by running ./gradlew check on your computer.

@Starlight220
Copy link
Member Author

I am simply looking at the check pipeline logs and commit a fix. The pipelines are automatically run when I add a commit. But thanks for the tip!

@AustinShalit
Copy link
Member

Looks like you have a trailing space.

@Starlight220
Copy link
Member Author

Where is the trailing space?

@PeterJohnson PeterJohnson changed the title Added documentation to prevent looping end() by scheduling commands, New commands: add docs to end() Mar 28, 2020
@PeterJohnson PeterJohnson merged commit d14978e into wpilibsuite:master Mar 28, 2020
@Starlight220 Starlight220 deleted the patch-3 branch March 28, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants