Fixes joystick button handling HAL JNI layer #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int, not a byte)
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@frcjenkins test this please |
|
@frcjenkins ok to test |
|
LGTM |
ThadHouse
approved these changes
Nov 11, 2016
|
Can we add a test for this? Do we have any joystick tests? |
|
We do not have any joystick or DS tests, as I don't think the test DS software has that capability. When we get around to #327 I'd like to see if there would be a way to add tests for things like this. |
333fred
approved these changes
Nov 11, 2016
pjbuterbaugh
pushed a commit
to pjbuterbaugh/allwpilib
that referenced
this pull request
Jun 15, 2023
* Clean up control system software page Fix missing links. Fixes wpilibsuite#339. Remove CTRE section. It was out of data and covered in third party libraries. Fix LabVIEW version and reference to eclipse add the notation for cross-platform software * No longer use asterisks to denote cross platform tools * fix length of headings Co-Authored-By: Austin Shalit <austinshalit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix issue #340 where joystick buttons >=8 do not work correctly in wpilibj.
Needed to update the HAL JNI layer to treat the button field as an int rather than a byte