Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmd] Change factories return type to CommandBase #4655

Merged
merged 1 commit into from Nov 17, 2022
Merged

[cmd] Change factories return type to CommandBase #4655

merged 1 commit into from Nov 17, 2022

Conversation

Starlight220
Copy link
Member

Fix #4603

@Starlight220 Starlight220 requested a review from a team as a code owner November 17, 2022 21:48
@PeterJohnson PeterJohnson merged commit e6392a1 into wpilibsuite:main Nov 17, 2022
@Starlight220 Starlight220 deleted the send-command branch November 21, 2022 17:58
rzblue added a commit to rzblue/allwpilib that referenced this pull request Nov 29, 2022
@rzblue
Update Subsystem facotries and example to return CommandBase
89f1dd9 
As in wpilibsuite#4655
rzblue added a commit to rzblue/allwpilib that referenced this pull request Nov 29, 2022
@rzblue
Update Subsystem factories and example to return CommandBase
1e15848 
As in wpilibsuite#4655
@rzblue rzblue mentioned this pull request Nov 29, 2022
Merged
PeterJohnson pushed a commit that referenced this pull request Nov 29, 2022
@rzblue
[commands] Update Subsystem factories and example to return CommandBa…
21003e3 
…se (#4729)

Also update rapidreactcommandbot example factories to fit this convention (as in #4655).

C++ does not need an update as CommandPtr already uses CommandBase (#4677).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterJohnson PeterJohnson PeterJohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Command factories and decorators don't return Sendable
2 participants
@Starlight220 @PeterJohnson