Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilib] Default LiveWindowEnabledInTest to false #5950

Merged
merged 3 commits into from Nov 23, 2023
Merged

[wpilib] Default LiveWindowEnabledInTest to false #5950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46a5194
[java] Default LiveWindowEnabledInTest=false
Starlight220 Nov 22, 2023
937d7e4
[cpp] Default LiveWindowEnabledInTest=false
Starlight220 Nov 22, 2023
c279c11
remove redundant initializer
Starlight220 Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions wpilibc/src/main/native/include/frc/IterativeRobotBase.h
View file
Open in desktop
Expand Up @@ -215,7 +215,7 @@ class IterativeRobotBase : public RobotBase {
/**
* Sets whether LiveWindow operation is enabled during test mode.
*
* @param testLW True to enable, false to disable. Defaults to true.
* @param testLW True to enable, false to disable. Defaults to false.
* @throws if called in test mode.
*/
void EnableLiveWindowInTest(bool testLW);
Expand Down Expand Up @@ -252,7 +252,7 @@ class IterativeRobotBase : public RobotBase {
units::second_t m_period;
Watchdog m_watchdog;
bool m_ntFlushEnabled = true;
bool m_lwEnabledInTest = true;
bool m_lwEnabledInTest = false;
bool m_calledDsConnected = false;

void PrintLoopOverrunMessage();
Expand Down
4 changes: 2 additions & 2 deletions wpilibj/src/main/java/edu/wpi/first/wpilibj/IterativeRobotBase.java
View file
Open in desktop
Expand Up @@ -70,7 +70,7 @@ private enum Mode {
private final double m_period;
private final Watchdog m_watchdog;
private boolean m_ntFlushEnabled = true;
private boolean m_lwEnabledInTest = true;
private boolean m_lwEnabledInTest;
private boolean m_calledDsConnected;

/**
Expand Down Expand Up @@ -260,7 +260,7 @@ public void setNetworkTablesFlushEnabled(boolean enabled) {
/**
* Sets whether LiveWindow operation is enabled during test mode. Calling
*
* @param testLW True to enable, false to disable. Defaults to true.
* @param testLW True to enable, false to disable. Defaults to false.
* @throws ConcurrentModificationException if this is called during test mode.
*/
public void enableLiveWindowInTest(boolean testLW) {
Expand Down