[commands] deprecate deadlineWith add deadlineFor #6544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacey-sooty
force-pushed
the
deadlinefor
branch
3 times, most recently
from
7392102
to
613c706
Compare
Starlight220
requested changes
Apr 27, 2024
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
Show resolved
Hide resolved
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/include/frc2/command/CommandPtr.h
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandDecoratorTest.java
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
deadlinefor
branch
2 times, most recently
from
99a4f0c
to
732c3b4
Compare
Starlight220
requested changes
Apr 28, 2024
wpilibNewCommands/src/main/native/include/frc2/command/CommandPtr.h
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/java/edu/wpi/first/wpilibj2/command/Command.java
Outdated
Show resolved
Hide resolved
spacey-sooty
force-pushed
the
deadlinefor
branch
from
732c3b4
to
af40d84
Compare
Starlight220
approved these changes
Apr 28, 2024
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Apr 29, 2024
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Apr 29, 2024
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Apr 29, 2024
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Apr 29, 2024
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Apr 29, 2024
spacey-sooty
added a commit
to spacey-sooty/robotpy-commands-v2
that referenced
this pull request
Apr 30, 2024
chauser
pushed a commit
to chauser/allwpilib
that referenced
this pull request
May 30, 2024
Deprecate deadlineWith for backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6538