Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added WPILib installer download instructions #1995

Merged
merged 3 commits into from Nov 22, 2022
Merged

Added WPILib installer download instructions #1995

merged 3 commits into from Nov 22, 2022

Conversation

amichaelyu
Copy link
Contributor

@amichaelyu amichaelyu commented Nov 20, 2022

Added instructions for downloading the WPILib installer to help people who might be unused to installing off of GitHub. Also fixes #1992.

@Daltz333
Copy link
Member

This change needs to be done to the prerequisites page as well

@amichaelyu
Copy link
Contributor Author

This change needs to be done to the prerequisites page as well

What if the offline installation preparation WPILib GitHub link was changed to direct to the more detailed guide?

@Daltz333
Copy link
Member

If we do that, we should do it the other way around. With the WPILib guide redirecting to prerequisites page.

@amichaelyu
Copy link
Contributor Author

If the offline pages links to the WPILib install, then we could have the more detailed instructions for running the installer, which is just a note right now.

Screenshot 2022-11-20 at 2 47 16 PM

Then another note could be added here, to say something like "If you want to create future offline installation click the Create VS Code zip to share with other computers/OSes for offline install"

Screenshot 2022-11-20 at 2 47 05 PM

@Daltz333
Copy link
Member

I'd argue that note belongs in the WPILib setup article and not there. Since prerequisites are the details of downloading and each installer has their respective installation article.

@amichaelyu
Copy link
Contributor Author

I think it might be better to just put it in both pages, as people might be confused by being redirected to a page called "Offline Installation Preparation".

@Daltz333 Daltz333 merged commit 369e095 into wpilibsuite:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention the Download is in the Assets section of the linked Github page
3 participants