-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rebuilds, add pre-commit #19
Conversation
@chrisjsewell I'm aiming to push a release tomorrow night around 10:30PM EST. |
Cool cheers If you don't mind I added a pre-commit config to the repo, and run the black CI via that (there's some other commented out checks you might consider adding) |
I'm also running the tests via tox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a dirhtml
test case similar to the html
test case you already added?
Sure! I'm open to the tox file. |
Done 👍 I figured out something a bit annoying; sphinx doesn't clean the build folder in-between each test. |
Yeah I just noticed that while working on the other open pr. I'll make an issue as we should clean the build folder before every test. |
Yeh I guess just make a new fixture: @pytest.fixture()
def app_clean(app):
if Path(app.outdir).exists():
shutil.rmtree(Path(app.outdir))
yield app (or clean after) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dirhtml test is using the html builder.
Co-authored-by: Vasista Vovveti <vasistavovveti@gmail.com>
Ooops my bad 🤦 |
LGTM. This will get merged in tomorrow. |
Brilliant, thanks for the great extension 😄 |
* Support rebuilds * Add pre-commit and CI * Add dirhtml test * Apply suggestions from code review Co-authored-by: Vasista Vovveti <vasistavovveti@gmail.com> Co-authored-by: Vasista Vovveti <vasistavovveti@gmail.com>
Fixes #18