Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild dist/ to _actually_ use notarytool, update to NodeJS 20 #7

Closed
wants to merge 2 commits into from
Closed

Rebuild dist/ to _actually_ use notarytool, update to NodeJS 20 #7

wants to merge 2 commits into from
+38,245 −11,173

Conversation

soundasleep
Copy link

@soundasleep soundasleep commented Apr 3, 2024 •
edited

It seems dist/ is still referencing altool, not notarytool, and thus fails.

In this PR I have rebuilt the dist/ using NodeJS v20.11.1 on Windows.

I also needed to update ncc to fix an unusual error when trying to npm install on Windows:

HookWebpackError: ENOENT: no such file or directory, open 'C:\package.json'

@PeterJohnson
Copy link
Member

Superseded by #6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@soundasleep @PeterJohnson