Field background: support showing image thumbnail instead of URL #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rilwis
requested changes
Dec 22, 2021
rilwis
requested changes
Dec 24, 2021
rilwis
requested changes
Dec 24, 2021
inc/fields/file-input.php
Outdated
| @@ -35,16 +35,23 @@ public static function admin_enqueue_scripts() { | |||
| */ | |||
| public static function html( $meta, $field ) { | |||
| $attributes = self::get_attributes( $field, $meta ); | |||
| $file_ext = strtolower( end( explode( '.', $meta ) ) ); | |||
| $expensions = [ 'jpeg', 'jpg', 'png', 'gif' ]; | |||
There was a problem hiding this comment.
Sửa tên biến nhé, viết sai chính tả :(.
inc/fields/file-input.php
Outdated
| </div>', | ||
| self::render_attributes( $attributes ), | ||
| esc_html__( 'Select', 'meta-box' ), | ||
| $meta ? '' : 'hidden', | ||
| esc_html__( 'Remove', 'meta-box' ) | ||
| esc_html__( 'Remove', 'meta-box' ), | ||
| ( !in_array( $file_ext, $expensions ) || empty( $meta ) ) ? 'rwmb-file-input-hidden-image' : '', |
There was a problem hiding this comment.
Chỗ điều kiện e nên sửa lại thành in_array( $file_ext, $extensions ) (tức là viết ngược lại). Viết dùng phủ định đọc ko xuôi. Khi viết ntn thì ko cần check empty( $meta ) nữa. Tên class e cũng để gọn thôi, rwmb-file-input-hidden.
| $el.closest( '.rwmb-file-input-inner' ).siblings( '.rwmb-file-input-image' ).removeClass( 'rwmb-file-input-hidden-image' ).html( '<img src="'+ url +'">' ) ; | ||
| } else { | ||
| $el.closest( '.rwmb-file-input-inner' ).siblings( '.rwmb-file-input-image' ).addClass( 'rwmb-file-input-hidden-image' ); | ||
| } |
There was a problem hiding this comment.
E viết ít chữ var đi nhé, và chỗ select cái image ý, cho nó vào 1 biến cho ngắn gọn nhé. Và có cần phải thay hẳn html của img ko? Hay chỉ cần update src cho nó là đc?
rilwis
deleted the
feature/background-field-show-selected-image-in-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.