Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oa-put: Use ogg extension instead of ogv #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update oa-put: Use ogg extension instead of ogv #144

wants to merge 1 commit into from

Conversation

maflcko
Copy link

@maflcko maflcko commented Sep 20, 2015

There are some false positives for video. Those audio files should then not be uploaded with the ogv extension. The ogg extension is more general.

This commit is a work around, not a proper fix but I don't have the time right now to look into #142 and #119. So this at least fixes the issue in the short term.

Also this is untested.

There are some false positives for video. Those audio files should then not be uploaded with the ogv extension. The ogg extension is more general.
@erlehmann
Copy link

I think this does not fix the issue. According to RFC 5334, section
10.3, “.ogg” serves as the file extension for files that have the MIME
type audio/ogg: “In particular, .ogg is used for Ogg files that contain
only a Vorbis bitstream”.

https://tools.ietf.org/html/rfc5334#section-10.3

MarcoFalke notifications@github.com writes:

There are some false positives for video. Those audio files should then not be uploaded with the ogv extension. The ogg extension is more general.

This commit is a work around, not a proper fix but I don't have the time right now to look into #142 and #119. So this at least fixes the issue in the short term.

Also this is untested.
You can view, comment on, or merge this pull request online at:

#144

-- Commit Summary --

  • Update oa-put

-- File Changes --

M oa-put (2)

-- Patch Links --

https://github.com/wpoa/open-access-media-importer/pull/144.patch
https://github.com/wpoa/open-access-media-importer/pull/144.diff


Reply to this email directly or view it on GitHub:
#144

Nils Dagsson Moskopp // erlehmann
http://dieweltistgarnichtso.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants