Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed deleteMessage #1954

Merged
merged 5 commits into from
Jun 6, 2024
Merged

fix: fixed deleteMessage #1954

merged 5 commits into from
Jun 6, 2024

Conversation

opsJson
Copy link
Contributor

@opsJson opsJson commented May 23, 2024

#1939 fixed.

@icleitoncosta
Copy link
Contributor

Great solution @opsJson.

Two things need to be checked.

We can't remove the chatId call, as we'll break any compatibility.
Did you test it on versions prior to 2.3000.x?

@opsJson
Copy link
Contributor Author

opsJson commented May 24, 2024

I reverted the chatId change,
I didn't test it before 2.3000.x.

@icleitoncosta
Copy link
Contributor

I'll test it, and then I'll accept the pr

@luidiva
Copy link

luidiva commented May 24, 2024

Eu fiz um teste rápido aqui mas parece que algumas propriedades o objeto de retorno como o "isRevoked", estão vindo null. Mas as msgs estão sendo apagadas

@opsJson
Copy link
Contributor Author

opsJson commented May 24, 2024

Pelo que vi, isRevoked estava setado para o valor de "isRevokedByMe", mas não tem mais essa propriedade no objeto da mensagem.

Tem essas opções:

isRevoked = msg.type == 'revoked';
isRevoked = Boolean(msg.revokeTimestamp);
isRevoked = msg.revokeSender._serialized == userWid;

Vou mandar um commit usando a primeira, mais simples e menos provável de deixar de valer com as futuras atualizações.

@opsJson
Copy link
Contributor Author

opsJson commented May 27, 2024

@icleitoncosta como faz pra testar nas versões anteriores a 2.3000.x.?

Tem que setar algum cookie pro servidor do Whatsapp me entregar os arquivos antigos?

@opsJson
Copy link
Contributor Author

opsJson commented May 28, 2024

Consegui testar, nas versões anteriores a 2.3000.x só funciona do jeito que estava mesmo.

@icleitoncosta icleitoncosta merged commit 6e71b0d into wppconnect-team:main Jun 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants