Support multiple nav menus #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # inc/Nav_Menus/Component.php
felixarntz
approved these changes
Jun 20, 2019
ataylorme
approved these changes
Jun 27, 2019
|
Let me look at this before merge. I too have modified this functionality for a client. Let me compare this with my code. |
@bamadesigner did you have a chance to compare this with your code? |
robruiz
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses issue #464.
Makes the component ready to store and register multiple nav menus with minimal changes.
When you declare a new menu location (eg. footer), you will need to add it in set_navs_menus.
List of changes
Checklist: