Refactor cron cleanup to improve DRYness

See wpsharks/comet-cache#613
wpsharks · Dec 7, 2015 · dbbb273 · dbbb273
1 parent 68744f3
commit dbbb273
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/includes/closures/Plugin/CronUtils.php b/src/includes/closures/Plugin/CronUtils.php
@@ -20,13 +20,12 @@
     return $schedules;
 };
 
-
 /*
  * Resets `crons_setup` and clears WP-Cron schedules.
  *
  * @since 15xxxx Fixing bug with Auto-Cache Engine cron disappearing in some scenarios
  *
- * @note This MUST happen upon uninstall and deactivation due to buggy WP_Cron behavior; see http://bit.ly/1lGdr78
+ * @note This MUST happen upon uninstall and deactivation due to buggy WP_Cron behavior. Events with a custom schedule will disappear when plugin is not active (see http://bit.ly/1lGdr78).
  */
 $self->resetCronsSetup = function ( ) use ($self) {
     if (is_multisite()) { // Main site CRON jobs.

diff --git a/src/includes/closures/Plugin/InstallUtils.php b/src/includes/closures/Plugin/InstallUtils.php
@@ -69,7 +69,7 @@
     $self->removeWpHtaccess();
     $self->removeAdvancedCache();
     $self->clearCache();
-    $self->resetCronsSetup(); // Events with a custom schedule will disappear (see http://bit.ly/1lGdr78); lets clean up to avoid any confusion.
+    $self->resetCronsSetup();
 };
 
 /*
@@ -93,7 +93,7 @@
     $self->removeWpHtaccess();
     $self->removeAdvancedCache();
     $self->wipeCache();
-    $self->resetCronsSetup(); // Events with a custom schedule will disappear (see http://bit.ly/1lGdr78); lets clean up to avoid any confusion.
+    $self->resetCronsSetup();
 
     if (!$self->options['uninstall_on_deletion']) {
         return; // Nothing to do here.