Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hourly option on purge_cache() method; See: websharks/zencache#472 #174

Merged
merged 2 commits into from
Nov 19, 2015

Conversation

kristineds
Copy link
Contributor

Add hourly option on purge_cache() method;

  • This is Step 1 of 2. Note: Don't merge yet until step 2 has been completed
  • Adding functionality for hourly option on purge_cache() method

See: wpsharks/comet-cache#472

@jaswrks
Copy link
Contributor

jaswrks commented Nov 17, 2015

@raamdev I am seeing a minor problem in this PR. I'll come back to this shortly and explain. It's nothing that Kristine introduced, but it looks like there is a minor bug in the existing release and we can knock that out as part of the work being done on this PR. More to come shortly...

@jaswrks
Copy link
Contributor

jaswrks commented Nov 17, 2015

@kristineds Next Actions

  • In this line change __NAMESPACE__ to GLOBAL_NS please.

  • Replace this line with the following:

    $this->updateOptions(array('crons_setup' => time().'-'.__NAMESPACE__.'-'.$this->options['cache_cleanup_schedule']));

@kristineds
Copy link
Contributor Author

@jaswsinc That has been updated. 👍 6ac79e9

@jaswrks
Copy link
Contributor

jaswrks commented Nov 18, 2015

@kristineds Perfect. Thanks!

@raamdev Kristine's last commit improves this PR and also resolves this bug.

@raamdev
Copy link
Contributor

raamdev commented Nov 18, 2015

@jaswsinc I'm not seeing that this is configurable (as discussed here). Can we at least make the schedule filterable?

@raamdev
Copy link
Contributor

raamdev commented Nov 18, 2015

@jaswsinc Sorry, I jumped the gun. :-) I didn't see that Step 2 had not yet been completed.

@raamdev
Copy link
Contributor

raamdev commented Nov 18, 2015

Oh, it has been finished, but in a separate PR: #180

@raamdev raamdev merged commit 6ac79e9 into 000000-dev Nov 19, 2015
@raamdev
Copy link
Contributor

raamdev commented Nov 19, 2015

Merged. Thank you, @kristineds! :-)

@raamdev raamdev deleted the feature/472 branch December 21, 2015 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants