Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in backwards compatibility for ZENCACHE_ALLOWED #218

Closed
wants to merge 4 commits into from
Closed

Fix bug in backwards compatibility for ZENCACHE_ALLOWED #218

wants to merge 4 commits into from

Conversation

raamdev
Copy link
Contributor

@raamdev raamdev commented Feb 24, 2016

@raamdev
Copy link
Contributor Author

raamdev commented Feb 24, 2016

@jaswsinc Quick review when you get a chance please.

@jaswrks
Copy link
Contributor

jaswrks commented Feb 24, 2016

Looks great! Nice catch on the lowercase issue.

One suggestion: Since this runs on every page view, I would try to optimize those calls to strtoupper(). It seems easy enough to run that once at the top of this method and then reuse a variable that contains the uppercase version in the rest of the sub-routines.

@raamdev
Copy link
Contributor Author

raamdev commented Feb 24, 2016

Since this runs on every page view, I would try to optimize those calls to strtoupper().

Ah, good idea. Thanks. Done: 3672068

@jaswrks
Copy link
Contributor

jaswrks commented Feb 27, 2016

This looks great to me.

@raamdev raamdev closed this Feb 27, 2016
@raamdev raamdev deleted the feature/683 branch February 27, 2016 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
2 participants
@raamdev @jaswrks