-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving inline docs for Misc. Auto Clear Options; #255
Conversation
@renzms The docs now say:
but the very next sentence contradicts this with the example used:
|
The first sentence was meant to explain that a specific URL to a single post/page needs to be in full for it to be detected and cleared properly. e.g., The second sentence refers to a category and wildcard for a catch-all, so supposedly multiple and not necessarily specific URLs. I don't think it contradicts, but maybe needs to be worded differently. |
@renzms According to your updated docs ("Relative links for specific URLs should not be used; e.g.,
So this sentence that follows would be incorrect:
And should instead say something like:
Also, as Jason noted here, we should clarify that a wildcard character can also be used to match all hostnames, e.g., |
@raamdev @jaswsinc Taking both of your notes into consideration, I've simplified the statement I added to the inline docs so it doesn't contradict other statements and to make it easier to understand. Thanks! |
@renzms Thanks. I think I may have found a bug in the Auto-Clear List of Custom URLs; see wpsharks/comet-cache#781 (comment). |
@renzms Please see Jason's comment here: wpsharks/comet-cache#781 (comment) So the docs need to be updated accordingly. Also, I noticed you're missing a space here after 'scheme': |
Ready for review thanks! |
@renzms Please post screenshots of the changes whenever your PR includes changes to the UI, otherwise whoever is reviewing the PR needs to rebuild the entire plugin and install it just to review the changes. |
@renzms I just reviewed this again: A few requested changes:Please strip out these two ambiguous sentences from the description:
Then add a blue informational note that goes at the bottom (under the text box) containing the following:
|
@raamdev : Updated, thanks! |
@renzms See my comment above about where the blue note box should go. Also, you're missing a bold Note: text. |
@raamdev Fixed! My bad. Thanks! |
see: wpsharks/comet-cache#781