Added Apache Optimization panel and features, edited Pro Features label

[renzms]

See wpsharks/comet-cache#554
See wpsharks/comet-cache#764
See wpsharks/comet-cache#765
See wpsharks/comet-cache#788

[renzms]

Removed GZIP Compression panel and added under new Apache Optimizations panel.

Work also done on to simplify Pro Preview Headers (see: wpsharks/comet-cache#788)

Lite

GZIP Compression feature now under Apache Optimization panel:

---

Lite + Pro Preview

GZIP Compression feature now under Apache Optimization panel:

---

Pro

New Pro Features:

• Leverage Browser Caching
• Automatic GZIP Compression
• Permalink structure via .htaccess

[renzms]

Noting an additional change by Jason here: wpsharks/comet-cache#764 (comment)

to remove:

<IfModule headers_module>
      <FilesMatch \.(?:js|css|xml|svg|xhtml|html|txt|ttf|otf|gz)$>
        Header append vary: accept-encoding
      </FilesMatch>
    </IfModule>

from gzip-enable.txt

[renzms]

@raamdev

Tested and Ready for review, see above comments for screenshots, updates and additional notes.

Thanks!

[raamdev]

Woooohoooo! This looks awesome! I'll review and test this soon and leave another update. Just wanted to share my excitement. 😁

[jaswrks]

Noting an additional change by Jason here: wpsharks/comet-cache#764 (comment)

Awesome! About a 9.5 on the attention scale there. I just posted this! haha.. Fantastic 💯

[renzms]

@raamdev

Tested for changes to .htaccess

[raamdev]

I pushed a bunch of changes to the Apache Optimizations panel in 603ca8c. Here's what it looks like now:

---

Things to do:

• Test that .htaccess rules are being added when these options are enabled (my most recent test revealed they were not being added, not even the rules that get added when Static CDN Filters is enabled).
• Refactor htaccess_client_side_cache_enable option to htaccess_browser_caching_enable instead to avoid confusion with existing Client-Side Cache feature (Jason agreed). This will also require renaming methods and files associated with this optimization.
• Refactor htaccess_permalink_structure_enable option to htaccess_enforce_canonical_urls. This will also require renaming methods and files associated with this optimization.
• Only show the Enforce Canonical URLs panel when !empty($GLOBALS['wp_rewrite']->permalink_structure) (i.e., when fancy Permalinks are being used).
• Test the Lite version to verify that Pro Preview works as expected and that auto-insertion of GZIP Compression rules works as expected (I decided to make this available in the Lite version to simplify things and also give Lite users a feel for how easy it is).

---

It's getting really late here, so I need to call it a day. I may come back to this over the weekend, otherwise I'll resume on Monday.

@renzms If you'd like to jump in and tackle any of those checklist items above, that would be great. 😄 Be sure to get the latest from this branch.

[raamdev]

@jaswsinc I could use another set of eyes on f8a3f19 just to double-check my work there. (EDIT: I forgot to rename BrowserUtils.php in this commit; fixed in 734609c .)

[raamdev]

• Need to fix issue with refactoring done in f8a3f19:

  Notice: Undefined index: COMET_CACHE_ALLOW_BROWSER_CACHE in /srv/www/wordpress-default/wp-content/plugins/comet-cache-pro/src/includes/classes/AdvCacheBackCompat.php on line 84
  

[jaswrks]

This looks great to me. However, you can optimize this further by ditching the section that collects user-defined constants; i.e., get rid of get_defined_constants() and instead of the in_array() check, just use if (defined('COMET_CACHE_ALLOW_BROWSER_CACHE')) {

The reason is because this back compat. routine is only looking for one specific constant and not any that have a special prefix like the other method does. So it's easier, and simpler will be equal to faster.

[raamdev]

@jaswsinc Done. 656098f Thanks! :-)

[renzms]

If you'd like to jump in and tackle any of those checklist items above, that would be great. 😄 Be sure to get the latest from this branch.

@raamdev

Things to do:

• Test that .htaccess rules are being added when these options are enabled - (Tested, no rules are being added)
• Test the Lite version to verify that Pro Preview works as expected and that auto-insertion of GZIP Compression rules works as expected - (Tested, GZIP rules not being added. Pro Preview is working)

---

Hi, pulled from the latest work from this branch, and tested.

I can confirm this current build does not add any new rules to the .htaccess file.

Expected output:

# BEGIN Comet Cache WmVuQ2FjaGU (the WmVuQ2FjaGU marker is required for Comet Cache; do not remove)
# GZIP compression.

<IfModule deflate_module>
  <IfModule filter_module>
    AddOutputFilterByType DEFLATE text/plain text/html
    AddOutputFilterByType DEFLATE text/xml application/xml application/xhtml+xml application/xml-dtd
    AddOutputFilterByType DEFLATE application/rdf+xml application/rss+xml application/atom+xml image/svg+xml
    AddOutputFilterByType DEFLATE text/css text/javascript application/javascript application/x-javascript
    AddOutputFilterByType DEFLATE font/opentype application/font-otf application/x-font-otf
    AddOutputFilterByType DEFLATE font/truetype application/font-ttf application/x-font-ttf
  </IfModule>
</IfModule>

# BEGIN s2Member GZIP exclusions
<IfModule rewrite_module>
    RewriteEngine On
    RewriteBase /
    RewriteCond %{QUERY_STRING} (^|\?|&)s2member_file_download\=.+ [OR]
    RewriteCond %{QUERY_STRING} (^|\?|&)no-gzip\=1
    RewriteRule .* - [E=no-gzip:1]
</IfModule>
# END s2Member GZIP exclusions

# BEGIN WordPress
<IfModule mod_rewrite.c>
RewriteEngine On
RewriteBase /
RewriteRule ^index\.php$ - [L]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /index.php [L]
</IfModule>

# END WordPress

Actual output:

# BEGIN s2Member GZIP exclusions
<IfModule rewrite_module>
    RewriteEngine On
    RewriteBase /
    RewriteCond %{QUERY_STRING} (^|\?|&)s2member_file_download\=.+ [OR]
    RewriteCond %{QUERY_STRING} (^|\?|&)no-gzip\=1
    RewriteRule .* - [E=no-gzip:1]
</IfModule>
# END s2Member GZIP exclusions

# BEGIN WordPress
<IfModule mod_rewrite.c>
RewriteEngine On
RewriteBase /
RewriteRule ^index\.php$ - [L]
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule . /index.php [L]
</IfModule>

# END WordPress

[raamdev]

@renzms Merged! :-) Thank you.