Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options panels do not have anchor tags #260

Closed
raamdev opened this issue Aug 4, 2014 · 3 comments
Closed

Options panels do not have anchor tags #260

raamdev opened this issue Aug 4, 2014 · 3 comments
Assignees
@jaswrks
Labels
bug lite pro
Milestone
v140829

Comments

@raamdev
Copy link
Contributor

raamdev commented Aug 4, 2014

The Quick Cache options panels (Dashboard → Quick Cache → Plugin Options) use DIVs with on-click JavaScript to expand/collapse them, instead of proper anchor tags (<a></a>). This breaks navigation with certain browser extensions, such as Vimium (an extension that allows you to navigate web pages using only the keyboard). The options panels should have proper anchor tags.

Related: #96.
@jaswrks jaswrks self-assigned this Aug 5, 2014
@jaswrks
Copy link

jaswrks commented Aug 5, 2014

Assigning this to myself. I will take a closer look at this.

jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Aug 5, 2014
Converting <div> to <a>. Working toward a resolution in wpsharks/come…
70d8164 
…t-cache#260
jaswrks pushed a commit that referenced this issue Aug 5, 2014
Converting <div> to <a>. Working toward a resolution in #260
93a4ee8
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Aug 5, 2014
<a> display:block; see wpsharks/comet-cache#260
fe81e99
jaswrks pushed a commit that referenced this issue Aug 5, 2014
<a> display:block; see #260
2842d27
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Aug 5, 2014
Update JS handler; see wpsharks/comet-cache#260
8e278b1
jaswrks pushed a commit that referenced this issue Aug 5, 2014
Update JS handler; see #260
11b3fe1
jaswrks pushed a commit to wpsharks/comet-cache-pro that referenced this issue Aug 5, 2014
Final tweaks and testing; see wpsharks/comet-cache#260
959ce2d
jaswrks pushed a commit that referenced this issue Aug 5, 2014
Final tweaks and testing; see #260
cccca29
This was referenced Aug 5, 2014
Closed
Closed
@jaswrks
Copy link

jaswrks commented Aug 5, 2014

This has been resolved in the feature/260 branch.

@raamdev
Copy link
Contributor Author

raamdev commented Aug 5, 2014

@jaswsinc Thanks! This has been merged. :)

Closed by PR #262.

@raamdev raamdev closed this as completed Aug 5, 2014
@raamdev raamdev added this to the Next Release milestone Aug 5, 2014
@raamdev raamdev mentioned this issue Apr 26, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaswrks jaswrks

Labels
bug lite pro
Projects
None yet
Milestone
v140829
Development

No branches or pull requests
2 participants
@raamdev @jaswrks