Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid Comet Cache Pro credentials gracefully #826

Open
raamdev opened this issue Sep 2, 2016 · 0 comments
Open

Handle invalid Comet Cache Pro credentials gracefully #826

raamdev opened this issue Sep 2, 2016 · 0 comments

Comments

@raamdev
Copy link
Contributor

raamdev commented Sep 2, 2016

In wpsharks/comet-cache-pro#272 we improved the Pro Upgrader by using the build-in WordPress upgrade system. However, if the wrong credentials are entered in the Comet Cache options, or if you've entered credentials and then cleared the credentials after a new version of Comet Cache Pro has been detected, attempting to update Comet Cache Pro results in the following confusing and misleading error:

2016-09-02_15-45-43

We can probably hook into upgrader_pre_download before the download is attempted to verify the credentials are correct, and then return our own WP_Error() when they're not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant