-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method for purging all post terms #117
Conversation
Awesome! I will test in just a moment. |
This is working great! Just tested it with Posts and also with a custom post type. One suggestion...
Here are some examples of the notice that I receive in the dashboard. The problem? Not really a problem. However, I think this notice could be more accurate, even if that means being less specific if we need to. This really should tell me something like, "found archive views; i.e. categories, tags and/or other terms". For instance, in the second example above there were actually three categories and two tags purged. Not just the one specific category that the notice listed for me. |
Interesting. I had not tested that but I thought, looking at the code, that it would display several notices for each one it was clearing. I'll take another look at this and get that fixed, as I agree it should definitely be more clear about that. |
Here's a thought... Most of the purging routines for Posts have the However, I wonder if that's wrong? Maybe a better solution would be to show only the first line, but add some HTML/JavaScript to toggle the remaining messages? There probably should still be a limit though. Like, no more than 100 lines (ever). |
Interesting. I totally missed that line However, I can see why it wasn't a problem until now: you'll only have 1 Home Page cache to clear, 1 Posts Page cache, and 1 Post Cache. Now that we're adding support for Tags and Categories (and other archive views, like Author Archives, eventually), we'll definitely need a better way of handling this.
I think that's a great idea! The message could say "Quick Cache: detected changes. Purging cache files. (click to see details)". Clicking to see the details would open a DIV below that which includes a log of sorts showing what types of cache files were created (essentially just the same messages we have now, minus the "Quick Cache: detected changes." part). I've never done a toggle inside a Dashboard message like that. Have you? |
Great! Well, WP loads jQuery in the dashboard so you can depend on that. |
Conflicts: quick-cache/quick-cache.inc.php Resolved conflict by adding auto_purge_post_terms_cache()
Awesome! |
When will this change released? I too had this problem in a long time in Quick Cache Pro version. |
@sarangandk It's coming within the next week or two. In the meantime, if you're interested in testing a beta release of Quick Cache before the next version comes out, please sign-up to be a beta tester here. |
@JasWSInc Could you review this for me?
000000-dev
into thepurge-post-terms
feature branch.E_NOTICE
-level errors triggered by unavailablechange_notifications_enable
option.