Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to default email templates that states replies will be public when using RVE #123

Closed
raamdev opened this issue Jul 22, 2015 · 7 comments
Assignees
Milestone

Comments

@raamdev
Copy link
Contributor

@raamdev raamdev commented Jul 22, 2015

When RVE (Replies via Email) is enabled, it's important that the default email template(s) include(s) a note that says:

Please Note: Your reply will be posted publicly and immediately.

That note should be included immediately after any instructions about how the reader can simply reply to the email to reply to the comment.

This is important because email is inherently private, so it would be easy for someone to hit reply on a notification and just assume that they're sending a private reply to the site owner! (I've had many readers do exactly that on my personal blog.)

@jaswrks
Copy link

@jaswrks jaswrks commented Jul 23, 2015

Next Actions

Prerequisites

Work on this issue requires a basic knowledge of PHP. It could be a good learning experience. If you need help editing the PHP template files referenced below, please feel free to ask for help on Slack in the #comment-mail channel.

~/projects/websharks Directory

Please create a folder in your HOME directory named: websharks; e.g., /Users/[YOURNAME]/websharks. This folder will be referenced in the instructions below, and it can be used as a place for all of your WebSharks-related projects to live.

Git Command-Line Tool

If you're running Windows, see: https://msysgit.github.io/
If you're running Mac, install via Homebrew: brew install git
If you're running on Linux: sudo apt-get install git


Clone Comment Mail and Comment Mail Pro Repos

$ git clone --recursive https://github.com/websharks/comment-mail-pro ~/projects/websharks/comment-mail-pro
$ git clone --recursive https://github.com/websharks/comment-mail ~/projects/websharks/comment-mail

You should now have two repos locally.

  • ~/projects/websharks/comment-mail-pro
  • ~/projects/websharks/comment-mail

Start Two New Feature Branches

Feature branches are going to be created so that your changes take place in a separate branch. After you complete work, you'll submit pull requests at GitHub requesting that changes in your feature branches be merged into the official copy.

Pro Version

$ cd ~/projects/websharks/comment-mail-pro # Move to the comment-mail-pro repo.
$ git checkout 000000-dev # Always start from the dev branch.
$ git pull # Make sure you have the latest copy of the dev branch.
$ git checkout -b feature/123 # Create and checkout a new feature branch.

Lite Version (Almost the Same)

$ cd ~/projects/websharks/comment-mail # Move to the comment-mail repo.
$ git checkout 000000-dev # Always start from the dev branch.
$ git pull # Make sure you have the latest copy of the dev branch.
$ git checkout -b feature/123 # Create and checkout a new feature branch.

Make Changes

Using an editor of your choosing, please follow this general outline:

Pro Version

Note: Any text that you add should be translatable. You can follow the examples in this template file already; e.g., <?php echo __('text goes here', $plugin->text_domain); ?>

Lite Version

The lite version comes with the simple templates only, so only one file to edit in the lite version.


Commit Changes

Pro Version

$ cd ~/projects/websharks/comment-mail-pro
$ git add --all && git commit -m 'Adding RVE instructions. See: websharks/comment-mail#123'
$ git push -u origin feature/123

Lite Version (Almost the Same)

$ cd ~/projects/websharks/comment-mail
$ git add --all && git commit -m 'Adding RVE instructions. See: websharks/comment-mail#123'
$ git push -u origin feature/123

Submit Pull Requests

Come to GitHub.com and submit two Pull Requests.

Pro Version

  • See this page which is a list of all pro branches.
  • Find your feature branch in the list; i.e., feature/123
  • Click "New Pull Request"
  • Enter a title; e.g., "RVE Instructions; see: #123"
  • Enter a body; e.g., "Closes #123"
  • Click submit.

Lite Version

  • See this page which is a list of all lite branches.
  • Find your feature branch in the list; i.e., feature/123
  • Click "New Pull Request"
  • Enter a title; e.g., "RVE Instructions; see: #123"
  • Enter a body; e.g., "Closes #123"
  • Click submit.
@jaswrks
Copy link

@jaswrks jaswrks commented Jul 23, 2015

Assigning this to @Reedyseth with a hope that he could help us with this one.

@Reedyseth
Copy link
Contributor

@Reedyseth Reedyseth commented Jul 23, 2015

Hey @jaswsinc I will take a look at this and let you know,

Reedyseth added a commit to wpsharks/comment-mail-pro that referenced this issue Jul 23, 2015
Reedyseth added a commit that referenced this issue Jul 23, 2015
@Reedyseth
Copy link
Contributor

@Reedyseth Reedyseth commented Jul 23, 2015

Done @raamdev @jaswsinc

image

@jaswrks jaswrks closed this in #128 Jul 24, 2015
jaswrks pushed a commit that referenced this issue Jul 24, 2015
Adding RVE instructions. See: #123
jaswrks pushed a commit to wpsharks/comment-mail-pro that referenced this issue Jul 24, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Oct 8, 2015

Next Lite Release Changelog:

  • Enhancement: Added a note to the default email templates when RVE (Replies via Email) is enabled, warning email readers that "Your reply will be posted publicly and immediately." Props @Reedyseth. See Issue #123.
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Oct 8, 2015

Next Pro Release Changelog:

  • Enhancement: Added a note to the default email templates when RVE (Replies via Email) is enabled, warning email readers that "Your reply will be posted publicly and immediately." Props @Reedyseth. See Issue #123.
@wpsharks wpsharks locked and limited conversation to collaborators Dec 24, 2015
@raamdev
Copy link
Contributor Author

@raamdev raamdev commented Dec 24, 2015

Comment Mail v151224 has been released and includes changes from this GitHub Issue: See the v151224 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#123).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants