Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS references inside complex conditional comments should be excluded #35

Closed
joeldbirch opened this issue Aug 27, 2014 · 6 comments
Closed
Labels

Comments

@joeldbirch
Copy link

@joeldbirch joeldbirch commented Aug 27, 2014

From the documentation it is clear that CSS files should be excluded when inside conditional comments. However, the following conditional breaks this. I'm using this to serve only IE9+ (and other browsers) a CSS file with media queries.

<!--[if (gte IE 9)|(gt IEMobile 7)|!(IE)]><!--><link rel="stylesheet" href="modern.css"><!--<![endif]-->

Love your work, by the way!
Joel.

@jaswrks jaswrks added the bug label Aug 27, 2014
@jaswrks
Copy link

@jaswrks jaswrks commented Aug 27, 2014

Hey, thanks for pointing this out! Adding this to my list.
Referencing: http://css-tricks.com/how-to-create-an-ie-only-stylesheet/
See also: http://msdn.microsoft.com/en-us/library/ms537512(v=vs.85).aspx

Loading

@joeldbirch
Copy link
Author

@joeldbirch joeldbirch commented Aug 27, 2014

Thanks for the quick response! I'm so excited that my favourite plugin (Quick Cache) can now also replace wp-minify, which I have been spending countless hours maintaining on life-support in recent years!

Loading

@jaswrks
Copy link

@jaswrks jaswrks commented Aug 27, 2014

Thanks for the quick response! I'm so excited that my favourite plugin (Quick Cache) can now also replace wp-minify

Very welcome! Me too :-) Same here.

Loading

@jaswrks
Copy link

@jaswrks jaswrks commented Aug 27, 2014

This has been fixed in the development copy. It will go out in a future release of Quick Cache Pro.

If you'd like to use the latest version of the HTML Compressor in the current copy of Quick Cache Pro, you can grab the dev branch for the HTML Compressor and replace: /wp-content/plugins/quick-cache-pro/submodules/htmlc with the latest copy.

Loading

@jaswrks jaswrks closed this Aug 27, 2014
@jaswrks
Copy link

@jaswrks jaswrks commented Aug 27, 2014

cc: @raamdev (QCP lead developer) ~ This fix will make it into the next official release of the HTML Compressor. I have a couple other issues I'd like to resolve before that happens, but I just wanted to give you a heads up.

Loading

@joeldbirch
Copy link
Author

@joeldbirch joeldbirch commented Aug 27, 2014

Amazing! Really appreciate this <3

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants