Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Bump in All Targets? #111

Closed
jaswrks opened this issue Jun 7, 2016 · 3 comments
Closed

Version Bump in All Targets? #111

jaswrks opened this issue Jun 7, 2016 · 3 comments

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Jun 7, 2016

@raamdev writes...

Well, it doesn't need to change in PRs... I was thinking the version number would only change in the distributable zip that gets generated (which we all use for building an installable version of our branch for testing purposes). The local working copy wouldn't have the version number changed, since that only needs to happen during a release when the bumped version number needs to be committed.

@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 7, 2016

I see. That sounds like it could work well then.

So we just need to get a version replacement routine into the build directory phase and have it run at all times instead of conditionally like the other one does. Do I have that right?

@raamdev
Copy link
Contributor

raamdev commented Jun 7, 2016

So we just need to get a version replacement routine into the build directory phase and have it run at all times instead of conditionally like the other one does. Do I have that right?

Yes, that sounds perfect. For everything except the release and release-rc, the version format could be something like v160606.80279, so that a developer running a build multiple times during the day and re-testing would see a different version number each time (as opposed to the same version number all day).

jaswrks pushed a commit that referenced this issue Jun 23, 2016
Adding `${_project_build_version}` in build directory phase. See: #111
@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 23, 2016

Next Release Changelog:

@jaswrks jaswrks closed this as completed Jun 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants