Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phing Email Key in .websharks.json #117

Closed
jaswrks opened this issue Jun 18, 2016 · 2 comments
Closed

Phing Email Key in .websharks.json #117

jaswrks opened this issue Jun 18, 2016 · 2 comments
Labels

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Jun 18, 2016

@raamdev writes...

My default email address in my global git config is xxxx@xxxxxxxx.com, as I have lots of other personal projects. In my WebSharks repos, I set my email address to xxxx@xxxxxxxxxxx so that's what shows up in my commits for those repos, however since Phing is cloning new repos and working from those, my global default email address gets used when Phing makes commits.

Propose that we read from .websharks.json when the repo is cloned:

"phings": {
    "git": {
        "email": "user@xxxxxxx.com"
    }
    "aws": {
      "salt": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
    }
  }
@jaswrks jaswrks added the bug label Jun 18, 2016
jaswrks pushed a commit that referenced this issue Jun 23, 2016
jaswrks pushed a commit that referenced this issue Jun 23, 2016
Set `user.email` in lite repo clone. See: #117
@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 23, 2016

Next Release Changelog:

@jaswrks jaswrks closed this as completed Jun 23, 2016
@jaswrks
Copy link
Contributor Author

jaswrks commented Jun 23, 2016

@raamdev Here's the data you need in .websharks.json for this to work. Actually, you only need the phings.github.email key, but please add the others for future implementation. Slack is coming soon also. I will post this in the README whenever I prepare the next release.

"phings": {
    "github": {
      "username": "",
      "email": "",
      "api_key": ""
    },
    "aws": {
      "access_key": "",
      "secret_key": "",
      "salt": ""
    },
    "slack": {
      "username": "",
      "email": "",
      "api_webhook_url": ""
    }
  }

Note: You can leave the Slack webhook URL empty for now. I'll post details about how to add this in the issue related to Slack notifications later. UPDATE: See: #108 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant